Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ssm-session-manager-plugin: migrate to buildGoModule #318850

Merged
merged 2 commits into from
Jul 21, 2024

Conversation

msanft
Copy link
Contributor

@msanft msanft commented Jun 10, 2024

Description of changes

Migrating to buildGoModule so buildGoPackage can be deprecated as per #318069.

Also moved to by-name.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@malt3
Copy link
Contributor

malt3 commented Jul 11, 2024

Result of nixpkgs-review pr 318850 run on x86_64-linux 1

3 packages built:
  • aws-gate
  • aws-gate.dist
  • ssm-session-manager-plugin

@amarshall
Copy link
Member

Please perform the move to by-name in a separate commit so Git can detect the rename and e.g. git log --follow works and diff is improved.

Copy link
Member

@amarshall amarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See also above comment about rename commit. I wasn’t able to fully review changes as the diff is hard to process as a result.

pkgs/by-name/ss/ssm-session-manager-plugin/package.nix Outdated Show resolved Hide resolved
Signed-off-by: Paul Meyer <49727155+katexochen@users.noreply.github.com>
Signed-off-by: Paul Meyer <49727155+katexochen@users.noreply.github.com>
@katexochen katexochen force-pushed the ssm-session-manager-plugin/build-go-module branch from dd03ac7 to bbb4986 Compare July 19, 2024 18:12
@Mic92 Mic92 merged commit 880af94 into NixOS:master Jul 21, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants