Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go-upower-notify: unstable-2016-03-10 -> 0-unstable-2019-01-06; migrate to buildGoModule #318082

Merged
merged 1 commit into from
Jun 13, 2024
Merged

go-upower-notify: unstable-2016-03-10 -> 0-unstable-2019-01-06; migrate to buildGoModule #318082

merged 1 commit into from
Jun 13, 2024

Conversation

katexochen
Copy link
Contributor

@katexochen katexochen commented Jun 7, 2024 •
edited
Loading

Description of changes

I'm not using this package. Upstream has been untouched for a long time, maybe we should just remove it. What do you think @kamilchm?

Patching in Go module support so it can be build with buildGoModule and buildGoPackage can be deprecated.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@katexochen
go-upower-notify: unstable-2016-03-10 -> 0-unstable-2019-01-06
e21eb95 
Migrate to buildGoModule.

Signed-off-by: Paul Meyer <49727155+katexochen@users.noreply.github.com>
@katexochen katexochen mentioned this pull request Jun 7, 2024
Open
35 tasks
@ofborg ofborg bot requested a review from kamilchm June 7, 2024 20:31
@katexochen katexochen merged commit a1a0c6a into NixOS:master Jun 13, 2024
38 checks passed
@katexochen katexochen deleted the go-upower-notify/mods branch June 13, 2024 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamilchm kamilchm kamilchm approved these changes

@msanft msanft msanft approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 2 12.approved-by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@katexochen @kamilchm @msanft