azure-cli-extensions.rdbms-connect: init at 1.0.6

[obreitwi]

Description of changes

• Added the azure-cli-extensions.rdbms-connect at v1.0.6.
• As drive-by, applied nixfmt-rfc-style to
  • pkgs/tools/admin/azure-cli/default.nix (in a separate commit)
  • pkgs/tools/admin/azure-cli/extensions-manual.nix
• Since rdbms-connect has its own dependencies, this required forwarding of propagatedBuildInputs of extensions to the base derivation.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[katexochen]

Why the reformatting?

[obreitwi]

Why the reformatting?

Was told in a different PR that nixpkgs is in the process of adapting a new linting style.

Hence I did a reformat beforehand for any file I touched. But, if there are efforts to reformat at once, I can also drop the commit.

Still new to nixpkgs and getting used to its customs.

[katexochen]

Why the reformatting?

Was told in a different PR that nixpkgs is in the process of adapting a new linting style.

Hence I did a reformat beforehand for any file I touched. But, if there are efforts to reformat at once, I can also drop the commit.

Still new to nixpkgs and getting used to its customs.

Such efforts with huge impact are always a bit of pain in nixpkgs. I asked the formatting team before but couldn't get a clear answer to whether individual packages should be formatted or not. I think many maintainers heard of the upcoming change an are just impatient. Thing is reformatting leads to merge conflicts with other PRs.

[katexochen]

Result of nixpkgs-review pr 317841 run on x86_64-linux 1

2 packages built:

• azure-cli-extensions.rdbms-connect
• azure-cli-extensions.rdbms-connect.dist

[obreitwi]

[...] Thing is reformatting leads to merge conflicts with other PRs.

Yeah, dropped the reformatting-commit when I rebased onto recently merged changes. 👌

[katexochen]

I've build the cli with the extension, built successfully and show the expected command in the help.

[katexochen]

Regarding the commit messages: Could you put the maintainers: add obreitwi commit first? So you don't need a separate commit and can squash chore: add obreitwi as maintainer into azure-extensions.rdbms-connect: init at 1.0.6.
fix: propagate build inputs of extensions should be be azure-cli: propagate build inputs of extensions.

[obreitwi]

Adjusted 👍

[katexochen]

@obreitwi Sorry, had to make some more adjustments.

• I've added a commit allowing to set meta.maintainers on the extensions. When asking you to add yourself as maintainer, I meant to the extension, not the whole azure-cli package, assuming that was possible, but it wasn't.
• I've moved your entry as maintainer over to the extension (now that this is possible).
• Fixed the formatting, using nixpkgs-fmt for now.
• I've scoped the with python3Packages; to a list of only the Python packages, and moved the other external dependency into a separate list. This is just for precaution and style, variables escaping a scope are discouraged (someone could add a mycli package to python packages and the meaning would change).

Thanks for the contribution and sorry for the back and forth. This is the first time someone adds an extension.

[obreitwi]

Thanks for the contribution and sorry for the back and forth. This is the first time someone adds an extension.

No problem, thank you for the feedback; always happy to learn 👍