pulumi-esc: init 0.9.0 #316044
Merged
pulumi-esc: init 0.9.0 #316044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t0yv0
reviewed
May 31, 2024
| ldflags = [ | ||
| "-s" | ||
| "-w" | ||
| "-X=github.com/pulumi/esc/cmd/esc/cli/version.Version=${src.rev}" |
There was a problem hiding this comment.
Brilliant, thank you for remembering to link in the version. Is src.rev going to be just "v0.9.0" no hash added?
There was a problem hiding this comment.
Yes, just comes out as "v0.9.0". Would you recommend doing it differently?
tomodachi94
suggested changes
May 31, 2024
There was a problem hiding this comment.
Mostly looks good. I suggest using nixfmt-rfc-style to format per RFC 166. Additionally, please change the Pulumi esc in the title to match the pname (here, this is pulumi-esc).
|
Done, and done. Thanks |
|
Result of 1 package built:
|
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
https://github.com/pulumi/esc
Pulumi ESC (Environments, Secrets, and Configuration)
First package, let me know if I need to make any changes.
Added package, added self as maintainer.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.