qt6.qtwebengine: fix QtWebEngine build crash #264497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QtWebEngine tries to build with clang 14, which links libc++ 14, but the top-level libc++ on Dariwn is libc++ 16. This results in a crash during the build, which is fixed by building with the default stdenv.
Specify a deployment target of 10.13 to avoid errors due to clang’s having a hard-coded check for 10.13 when using them (even though it implements them with `posix_memalign`, which is available on earlier versions of macOS).
reckenrode
force-pushed
the
qtwebengine-fix
branch
from
12e7e6a
to
3f3a594
Compare
wegank
approved these changes
Oct 31, 2023
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
QtWebEngine tries to build with clang 14, which links libc++ 14, but the top-level libc++ on Dariwn is libc++ 16. This results in a crash during the build, which is fixed by building with the default stdenv.
This PR also updates the deployment target to support aligned allocations on x86_64-darwin. This includes an update to
overrideSDKto override xcbuild automatically with the requested SDK version and deployment target.Note that this is not yet failing to build on staging-next yet because it depends on nodejs_18, which does not build, but it is expected to crash once #263847 is merged into staging-next #263535.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)