nodejs_18: fix build with clang 16 #263847
Conversation
pkgs/development/web/nodejs/v18.nix
Outdated
|
|
||
| let | ||
| # Clang 16+ cannot build Node v14 due to -Wenum-constexpr-conversion errors. |
There was a problem hiding this comment.
Nit: did you mean Node v18 here, or did I misunderstand something?
There was a problem hiding this comment.
Copy-paste mistake. It’s the same solution as nodejs_14 copied into nodejs_18. I can push an update that corrects the comment.
There was a problem hiding this comment.
Thank you. An update wasn't necessary; I'm just an eager onlooker from the peanut gallery.
|
Edit: That PR is past the breaking changes deadline for LLVM, so this is the preferred one for 23.11. |
This reverts commit 81e4ca5.
Trying to backport the fixes from v8 caused crashes with npm when building other packages, so just build it with clang 15.
reckenrode
force-pushed
the
nodejs18-fix
branch
from
ede922b
to
b034e4c
Compare
Isn't normally the easiest approach to just avoid such errors by using a EDIT: just as a quick question. I haven't tried to really review this PR in detail. |
It’s (probably) going to be made a hard error in a future version of clang (see llvm/llvm-project#59036). Pinning the version to clang 15 avoids possible future breakage. |
|
OK, I think there's been enough time for feedback. |
Description of changes
While node v18 successfully built, it was crashing in staging-next #263535 while building packages. This patch reverts the previous attempt at a fix and builds nodejs_18 with clang 15 instead. paperless-ngx.frontend was confirmed to successfully build with this patch applied.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)