Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scrcpy: make server display nicer in nix store diff-closure #243832

Merged
merged 1 commit into from
Jul 16, 2023

Conversation

SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Jul 16, 2023

Before it was displayed as:
scrcpy-server-v2.1: ε → ∅, -55.7 KiB
scrcpy-server-v2.1.1: ∅ → ε, +55.8 KiB

Now the version number is correct:
scrcpy-server: ∅ → 2.1.1, +55.8 KiB

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Before it was displayed as:
scrcpy-server-v2.1: ε → ∅, -55.7 KiB
scrcpy-server-v2.1.1: ∅ → ε, +55.8 KiB

Now the version number is correct:
scrcpy-server: ∅ → 2.1.1, +55.8 KiB
Copy link
Contributor

@msfjarvis msfjarvis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL you can name and version a fetchurl call :)

LGTM

@SuperSandro2000
Copy link
Member Author

I've added that in #194425

@SuperSandro2000 SuperSandro2000 merged commit 916fd5c into NixOS:master Jul 16, 2023
14 of 15 checks passed
@SuperSandro2000 SuperSandro2000 deleted the scrcpy branch July 16, 2023 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants