-
-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for pname+version to fetchzip/fetchurl #194425
Merged
AndersonTorres
merged 8 commits into
NixOS:master
from
SuperSandro2000:remove-double-fixed-output
Oct 7, 2022
Merged
Add support for pname+version to fetchzip/fetchurl #194425
AndersonTorres
merged 8 commits into
NixOS:master
from
SuperSandro2000:remove-double-fixed-output
Oct 7, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 73e9cb6.
SuperSandro2000
changed the title
Revert "ubuntu-font-family: use mkDerivation"
Add support for pname+version to fetchzip/fetchurl
Oct 4, 2022
This reverts commit 9debb92.
FYI @erdnaxe |
SuperSandro2000
force-pushed
the
remove-double-fixed-output
branch
from
October 4, 2022 16:57
3a0c00f
to
d2ff852
Compare
ofborg
bot
added
10.rebuild-darwin: 1-10
10.rebuild-darwin: 1
10.rebuild-linux: 1-10
10.rebuild-linux: 1
and removed
10.rebuild-darwin: 0
10.rebuild-linux: 0
labels
Oct 4, 2022
SuperSandro2000
force-pushed
the
remove-double-fixed-output
branch
from
October 4, 2022 18:23
d2ff852
to
fdd0db3
Compare
7 tasks
7c6f434c
reviewed
Oct 5, 2022
7c6f434c
approved these changes
Oct 5, 2022
erdnaxe
approved these changes
Oct 6, 2022
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
After this commit the font was in a double fixed output derivation wrapped which is unnecessary.
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes