-
-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python310Packages.pillow: 9.4.0 -> 9.5.0 #228493
Conversation
The header issue has been fixed upstream in python-pillow/Pillow#7069. |
Also you have a typo in the commit title: it should be python310Packages |
aaaa52b
to
817715d
Compare
817715d
to
d0f2ea3
Compare
Did you consider just fetching this commit instead? This PR rebuilds a lot of packages which means we must target staging. Please follow the contributing guide to not potentially ping a lot of people. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, this should just apply the patch from python-pillow/Pillow#7069
As this seems stale I created #241913 to supersede it. |
Description of changes
Pillow changelog: https://github.com/python-pillow/Pillow/blob/main/CHANGES.rst#950-2023-04-01
Note that this MR reverts an upstream commit (04cf5e2cfc5dc1676efd9f5c8d605ddfccb0f9ee) as it prevents pillow from finding its native dependencies during the build. We should probably try to fix the underlying issue, but I'm having trouble understanding what the patch even does.
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)