Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fs-uae-launcher Qt wrapping issue #194206

Merged
merged 1 commit into from
Oct 6, 2022
Merged

Fix fs-uae-launcher Qt wrapping issue #194206

merged 1 commit into from
Oct 6, 2022

Conversation

PanAeon
Copy link
Contributor

@PanAeon PanAeon commented Oct 3, 2022

Should fix #161716

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

AndersonTorres
AndersonTorres suggested changes Oct 5, 2022
View reviewed changes
Copy link
Member

@AndersonTorres AndersonTorres left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Squash all commits into one, and write the commit message as

fs-uae-launcher: fix Qt wrapping issue

Fixes #161716

Otherwise, LGTM.

@ofborg ofborg bot requested a review from AndersonTorres October 5, 2022 11:30
IvarWithoutBones
IvarWithoutBones approved these changes Oct 5, 2022
View reviewed changes
Copy link
Member

@IvarWithoutBones IvarWithoutBones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@AndersonTorres AndersonTorres merged commit cabcec1 into NixOS:master Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IvarWithoutBones IvarWithoutBones IvarWithoutBones approved these changes

@svanderburg svanderburg Awaiting requested review from svanderburg

@AndersonTorres AndersonTorres Awaiting requested review from AndersonTorres

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fs-uae-launcher: Qt issues?
4 participants
@PanAeon @AndersonTorres @IvarWithoutBones @bobby285271