Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

goimapnotify: Add darwin to platforms #193797

Merged
merged 2 commits into from
Oct 6, 2022
Merged

goimapnotify: Add darwin to platforms #193797

merged 2 commits into from
Oct 6, 2022

Conversation

dbaynard
Copy link
Contributor

@dbaynard dbaynard commented Oct 1, 2022

The program builds and runs on macos.

Description of changes

I've just enabled darwin platforms in the metadata. This should be fine to backport, too.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

The program builds and runs on macos.
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Oct 1, 2022
@dbaynard
Copy link
Contributor Author

dbaynard commented Oct 1, 2022

I don't see how to add labels to trigger the backport CI (I don't have permission , no?)

@marsam marsam merged commit 6d0224c into NixOS:master Oct 6, 2022
@dbaynard dbaynard deleted the patch-2 branch October 7, 2022 16:33
@dbaynard
Copy link
Contributor Author

dbaynard commented Oct 7, 2022

Thanks! Good to know about the default go platforms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants