-
-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixos/tmate-ssh-server: init module #192270
Conversation
77dcec5
to
3df1b7f
Compare
3df1b7f
to
3f6da6f
Compare
While working on NixOS#192270, I noticed that only some wait_for_* helper functions make the timeout configurable. I think we should be able to customize it in all cases
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Likely want to add yourself to maintainers. The tests fail, but ofborg seems to consider that a "neutral outcome". Wanna try and fix them? |
For some reason running the tests with nix run .#nixosTests.tmate-ssh-server.driver worked, but running with nix-build ./nixos/release.nix -A tests.tmate-ssh-server did not.
538f761
to
0627875
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Module LGTM 👍
Co-authored-by: Aaron Andersen <aaron@fosslib.net>
While working on NixOS#192270, I noticed that only some wait_for_* helper functions make the timeout configurable. I think we should be able to customize it in all cases
While working on NixOS#192270, I noticed that only some wait_for_* helper functions make the timeout configurable. I think we should be able to customize it in all cases
While working on NixOS#192270, I noticed that only some wait_for_* helper functions make the timeout configurable. I think we should be able to customize it in all cases
While working on NixOS#192270, I noticed that only some wait_for_* helper functions make the timeout configurable. I think we should be able to customize it in all cases
While working on NixOS#192270, I noticed that only some wait_for_* helper functions make the timeout configurable. I think we should be able to customize it in all cases
Description of changes
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes