Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/tmate-ssh-server: init module #192270

Merged
merged 4 commits into from
Oct 5, 2022

Conversation

jlesquembre
Copy link
Member

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

jlesquembre added a commit to jlesquembre/nixpkgs that referenced this pull request Sep 23, 2022
While working on NixOS#192270, I noticed that only some wait_for_* helper
functions make the timeout configurable. I think we should be able to
customize it in all cases
Copy link
Contributor

@ck3d ck3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkaito
Copy link
Contributor

mkaito commented Sep 30, 2022

@ofborg test tmate-ssh-server
@ofborg build tmate-ssh-server

@mkaito
Copy link
Contributor

mkaito commented Sep 30, 2022

Likely want to add yourself to maintainers.

The tests fail, but ofborg seems to consider that a "neutral outcome". Wanna try and fix them?

For some reason running the tests with
nix run .#nixosTests.tmate-ssh-server.driver
worked, but running with
nix-build ./nixos/release.nix -A tests.tmate-ssh-server
did not.
@jlesquembre
Copy link
Member Author

@ofborg test tmate-ssh-server
@ofborg build tmate-ssh-server

@jlesquembre
Copy link
Member Author

jlesquembre commented Oct 3, 2022

For some reason running the tests with nix run .#nixosTests.tmate-ssh-server.driver
worked, but running with nix-build ./nixos/release.nix -A tests.tmate-ssh-server did not. With the changes in 0627875 should work on both cases.

@mkaito I also added myself as maintainer.

Copy link
Contributor

@mkaito mkaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Module LGTM 👍

Co-authored-by: Aaron Andersen <aaron@fosslib.net>
@mkaito mkaito merged commit 396f4f0 into NixOS:master Oct 5, 2022
@jlesquembre jlesquembre deleted the nixos/tmate-ssh-server branch October 5, 2022 16:52
Artturin pushed a commit to jlesquembre/nixpkgs that referenced this pull request Sep 20, 2023
While working on NixOS#192270, I noticed that only some wait_for_* helper
functions make the timeout configurable. I think we should be able to
customize it in all cases
Artturin pushed a commit to jlesquembre/nixpkgs that referenced this pull request Sep 20, 2023
While working on NixOS#192270, I noticed that only some wait_for_* helper
functions make the timeout configurable. I think we should be able to
customize it in all cases
Artturin pushed a commit to jlesquembre/nixpkgs that referenced this pull request Sep 20, 2023
While working on NixOS#192270, I noticed that only some wait_for_* helper
functions make the timeout configurable. I think we should be able to
customize it in all cases
Artturin pushed a commit to jlesquembre/nixpkgs that referenced this pull request Sep 20, 2023
While working on NixOS#192270, I noticed that only some wait_for_* helper
functions make the timeout configurable. I think we should be able to
customize it in all cases
toastal pushed a commit to toastal/nixpkgs that referenced this pull request Sep 25, 2023
While working on NixOS#192270, I noticed that only some wait_for_* helper
functions make the timeout configurable. I think we should be able to
customize it in all cases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants