-
-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aws: remove, recommend awscli
/ awscli2
#176707
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Diff and ofborg LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nixpkgs-review was also happy.
todo (self-note): add a note to the 22.11 release notes |
@kubukoz Please fix the conflict. |
@kubukoz Please fix the conflict. And report back. |
@superherointj I'll update it some day this week, in general I want to tackle the changelog at the same time and I haven't found the energy to actually do it 😅 |
ping @kubukoz |
Done - sorry for the long wait. Added a note to the release notes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and ofborg is happy.
Thanks.
Waiting for CI, requires Squash merge. |
@ofborg eval |
Closes #176706
Description of changes
Removes the
aws
package.Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes