Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cppzmq: align drafts CMake flag with zeromq #126053

Closed
wants to merge 1 commit into from
Closed

cppzmq: align drafts CMake flag with zeromq #126053

wants to merge 1 commit into from

Conversation

panicgh
Copy link
Contributor

@panicgh panicgh commented Jun 7, 2021

Motivation for this change

The zeromq pkg has an enableDrafts attribute which sets the CMake
flag ENABLE_DRAFTS=ON. This makes library functions under development
visible. This change aligns cppzmq to enable draft functions when they
are enabled in zeromq.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

cppzmq: align drafts CMake flag with zeromq
d67e121 
The `zeromq` pkg has an `enableDrafts` attribute which sets the CMake
flag `ENABLE_DRAFTS=ON`. This makes library functions under development
visible. This change aligns `cppzmq` to enable draft functions when they
are enabled in `zeromq`.
@panicgh
Copy link
Contributor Author

panicgh commented Jul 16, 2021

There is a discussion upstream how ENABLE_DRAFTS should be propagated from libzmq to cppzmq:

Therefore I close this PR.

@panicgh panicgh closed this Jul 16, 2021
@panicgh panicgh deleted the cppzmq-enabledrafts branch July 16, 2021 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@panicgh