-
-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
darwin.adv_cmds: fix build #103180
darwin.adv_cmds: fix build #103180
Conversation
Also disable pgrep that depends on pkill
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Unfortunately, I can’t easily reproduce the issues that I was having (I don’t have access to a darwin machine, and this was on CI for a project where I cannot just test this patch.)
So installation was broken when implemented 4f52264, but I suppose it would only fail the build after #72347. Other places seem to have been fixed (e.g. ed61487):
|
Still includes `coreutils` in `checkInputs`. macOS: disables some pexpect tests which depend on pkill/pgrep (see #103180).
Also disable pgrep that depends on pkill (cherry picked from commit f0efe2d) cc NixOS#103180
Also disable pgrep that depends on pkill
Motivation for this change
Closes: #82640
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)