darwin is missing pgrep and pkill

[uri-canva]

Describe the bug

There are no pgrep and pkill available on darwin.

nixpkgs/pkgs/os-specific/darwin/apple-source-releases/adv_cmds/default.nix

Line 21 in 0c41607

| grep -v -e Desktop -e Embedded -e mklocale -e pkill -e pgrep -e colldef)

They were excluded in #103180, but they were probably broken by an SDK update before that.

Additional context

This is related to the Apple open source distribution being a bit broken.

Notify maintainers

@matthewbauer, also related to the issues @toonn is hitting with the SDK upgrade.

Metadata

• system: "x86_64-darwin"
• host os: Darwin 20.6.0, macOS 10.16
• multi-user?: yes
• sandbox: no
• version: nix-env (Nix) 2.3.12
• channels(root): "darwin, nixpkgs-21.11pre299952.7918dc5148d"
• channels(uri): "darwin"
• nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixpkgs

[toonn]

Fwiw, I haven't run into any problems related to pgrep/pkill missing. The linked PR (#141159) seems to say pkill builds but hangs. That sounds like a bad thing to run into down the line, an error about the command being missing would be better than an obscure timeout due to something hanging.

@uri-canva, do you know more about this, do these commands actually provide some headers I am missing or something?

[uri-canva]

I agree it is better for the commands to be entirely missing than to be present but behave incorrectly.

I did not hit any issues with them missing as dependencies of something else, I just needed to use pgrep on macOS, and found out it wasn't part of nixpkgs.procps as it is on Linux.

[risicle]

This is frustrating because macos' ps is missing useful features like selecting by parent pid, which could otherwise be worked around by using pgrep.

[reckenrode]

After I finish the system_cmds update, I can take a look at adv_cmds next. The plan is to go through each of the *_cmds and update them, so it’s just a matter of prioritization.