Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable ctap-keyring-device on Windows with Python3.10+ #465

Merged
merged 6 commits into from
May 9, 2024
Merged

Conversation

epierce
Copy link
Member

@epierce epierce commented May 9, 2024

Description

All of the released versions of ctap-keyring-device require winRT on Windows, which does not support Python 3.10+ Support for the replacement library (winSDK) was added to ctap-keyring-device in 2022, but it still hasn't been released and the project appears to be abandoned. We will likely need to fork the project to release a new version, but that's a longer-term project. My first priority is making it possible to install the latest version of gimme-aws-creds on Windows with a Python version newer than 3.9.

The obvious downside of not having access to the ctap-keyring-device library is that WebAuthn support will not be available in Windows with Python 3.10+, but all other factors will be available. This change only affects Windows running Python 3.10+ - all other platforms/Python versions retain WebAuthn functionality.

Related Issue

#435
#430
#337
#320

Motivation and Context

Downgrading Python to use gimme-aws-creds isn't a valid option for Windows users. Binaries for the latest version of Python 3.9 are no longer available for Windows anyway. This makes it possible to use the latest version without support WebAuthn factors

How Has This Been Tested?

Tested on Windows 11 with Python 3.9, 3.12 and 3.13
WebAuthn support tested an working on

  • Windows 11 - Python 3.9
  • macOS - Python 3.12
  • Linux - Python 3.7, 3.8, 3.9, 3.10

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

the current version of ctap-keychain-device doesn't support Python 3.10+ on Windows. We're losing WebAuthn functionality on that platform, but this makes it possible to install gimme-aws-creds
@epierce epierce merged commit cb39928 into master May 9, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant