Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the use of system keychain optional #440

Merged
merged 2 commits into from
Nov 20, 2023
Merged

Make the use of system keychain optional #440

merged 2 commits into from
Nov 20, 2023

Conversation

epierce
Copy link
Member

@epierce epierce commented Nov 20, 2023

Description

Added a new config option (enable_keychain) and CLI parameter (--disable-keychain). enable_keychain defaults to TRUE so that existing behavior is not affected. If --disable-keychain is used or enable_keychain = False, the system keychain will not be used and the user will always be prompted for their password.

Related Issue

#212

Motivation and Context

Some organizations may want to avoid the storage of user credentials and force the user to input their password on every use.

How Has This Been Tested?

tested on macOS 13.6 with Python 3.11.6

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@epierce epierce merged commit 72c2074 into master Nov 20, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant