Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send all user messages to STDERR when writing to credentials file #401

Merged
merged 3 commits into from
May 15, 2023

Conversation

epierce
Copy link
Member

@epierce epierce commented May 15, 2023

Description

Running $(gimme-aws-creds) would fail when writing to a credentials file because notices to the user were written to STDOUT instead of STDERR. This change sends all messages to the user using STDERR.

Related Issue

#156

How Has This Been Tested?

tested on macOS Ventura with Python 3.11

Types of changes

  • [x ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [x ] My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • [ x] I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • [ x] All new and existing tests passed.

epierce and others added 3 commits May 4, 2023 12:27
Merge Master into dev branch
For consistency, all messages to the user are sent over STDERR.
@epierce epierce merged commit 679c30f into master May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant