-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
run aws session sts code asyncronously vastly improving the performance. #348
Conversation
eedgar
commented
Apr 3, 2022
- log success to user
- add threads to speedup execution when you have a large number of roles
This is much faster when you have a large number of roles. as long as a new session is created in each thread the boto module becomes threadsafe. See https://stackoverflow.com/questions/52820971/is-boto3-client-thread-safe for more info. I could see this pr being parameterized and the threading capabilities become optional with the default being the old style. This pr works for me .. and is meant to get a discussion on speeding up the calls to aws. |
@Sector95 Any chance I could get a review on this? As it stands its working for me and I see a huge performance boost from it. Just wanted to share the idea with others. |
@bwynsm would be a better contact for this, I'm not really involved with the project anymore. |
this is great! was trying to find a solution to help with the 5 min sts max limit since I'm pulling a 100+ roles, this cut the time down to less than a minute! |
@bwynsm Any chance we can get a review / update on how we get this one merged? |
@epierce I see you have recently merged code.. can this be merged also? |
Everything looks good with this - it's working fine for me. Thanks for the contribution |