Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run aws session sts code asyncronously vastly improving the performance. #348

Merged
merged 2 commits into from
Dec 13, 2022

Conversation

eedgar
Copy link
Contributor

@eedgar eedgar commented Apr 3, 2022

  • log success to user
  • add threads to speedup execution when you have a large number of roles

@eedgar
Copy link
Contributor Author

eedgar commented Apr 3, 2022

This is much faster when you have a large number of roles. as long as a new session is created in each thread the boto module becomes threadsafe. See https://stackoverflow.com/questions/52820971/is-boto3-client-thread-safe for more info.

I could see this pr being parameterized and the threading capabilities become optional with the default being the old style. This pr works for me .. and is meant to get a discussion on speeding up the calls to aws.

@eedgar eedgar changed the title async run aws session sts code asyncronously vastly improving the performance. Apr 4, 2022
@eedgar
Copy link
Contributor Author

eedgar commented Apr 21, 2022

@Sector95 Any chance I could get a review on this? As it stands its working for me and I see a huge performance boost from it. Just wanted to share the idea with others.

@Sector95
Copy link
Contributor

@bwynsm would be a better contact for this, I'm not really involved with the project anymore.

@aaa-khoa
Copy link

this is great! was trying to find a solution to help with the 5 min sts max limit since I'm pulling a 100+ roles, this cut the time down to less than a minute!

@Rooks103
Copy link

@bwynsm Any chance we can get a review / update on how we get this one merged?

@eedgar
Copy link
Contributor Author

eedgar commented Dec 13, 2022

@epierce I see you have recently merged code.. can this be merged also?

@epierce
Copy link
Member

epierce commented Dec 13, 2022

Everything looks good with this - it's working fine for me. Thanks for the contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants