Bump axe-core to v4.5.1 #251
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 31, 2022 17:30
AriPerkkio
suggested changes
Nov 1, 2022
There was a problem hiding this comment.
I would suggest to wait for next patch release due to dequelabs/axe-core#3753.
You can see those errors by adding some <style> tags here:
jest-axe/__tests__/index.test.js
Lines 24 to 32 in 208e197
const goodHtmlExample = `
<html>
+ <head>
+ <style>
+ a { color: red; }
+ </style>
+ </head>
<body>Warnings seen in your branch with those changes:
PASS __tests__/index.test.js
● Console
console.warn
Couldn't load preload assets: TypeError: Cannot read properties of undefined (reading 'mediaText')
at /workspaces/jest-axe/node_modules/axe-core/axe.js:12577:47
at Array.filter (<anonymous>)
at getStylesheetsFromDocument (/workspaces/jest-axe/node_modules/axe-core/axe.js:12576:47)
at getStylesheetsOfRootNode (/workspaces/jest-axe/node_modules/axe-core/axe.js:12557:18)
at /workspaces/jest-axe/node_modules/axe-core/axe.js:12527:22
at Array.forEach (<anonymous>)
at getCssomForAllRootNodes (/workspaces/jest-axe/node_modules/axe-core/axe.js:12525:17)
at Object.preloadCssom [as cssom] (/workspaces/jest-axe/node_modules/axe-core/axe.js:12502:14)
at /workspaces/jest-axe/node_modules/axe-core/axe.js:12692:44
at Array.map (<anonymous>)
at /workspaces/jest-axe/node_modules/axe-core/axe.js:12691:28
at new Promise (<anonymous>)
at preload (/workspaces/jest-axe/node_modules/axe-core/axe.js:12686:14)
at /workspaces/jest-axe/node_modules/axe-core/axe.js:22426:15
at pop (/workspaces/jest-axe/node_modules/axe-core/axe.js:6501:18)
at Object.defer (/workspaces/jest-axe/node_modules/axe-core/axe.js:6523:11)
at Audit.run (/workspaces/jest-axe/node_modules/axe-core/axe.js:22425:28)
at /workspaces/jest-axe/node_modules/axe-core/axe.js:22710:15
at pop (/workspaces/jest-axe/node_modules/axe-core/axe.js:6501:18)
at Object.defer (/workspaces/jest-axe/node_modules/axe-core/axe.js:6523:11)
at Object.runRules [as _runRules] (/workspaces/jest-axe/node_modules/axe-core/axe.js:22709:9)
at Object.run (/workspaces/jest-axe/node_modules/axe-core/axe.js:22958:11)
at /workspaces/jest-axe/index.js:68:15
at new Promise (<anonymous>)
at axe (/workspaces/jest-axe/index.js:67:12)
at Object.<anonymous> (/workspaces/jest-axe/__tests__/index.test.js:68:13)
at Object.asyncJestTest (/workspaces/jest-axe/node_modules/jest-jasmine2/build/jasmineAsyncInstall.js:106:37)
at /workspaces/jest-axe/node_modules/jest-jasmine2/build/queueRunner.js:45:12
at new Promise (<anonymous>)
at mapper (/workspaces/jest-axe/node_modules/jest-jasmine2/build/queueRunner.js:28:19)
at /workspaces/jest-axe/node_modules/jest-jasmine2/build/queueRunner.js:75:41
at node_modules/axe-core/axe.js:22429:25
AriPerkkio
suggested changes
Nov 2, 2022
package.json
Outdated
| @@ -24,7 +24,7 @@ | |||
| "node": ">= 10.0.0" | |||
| }, | |||
| "dependencies": { | |||
| "axe-core": "4.4.1", | |||
| "axe-core": "4.5.0", | |||
There was a problem hiding this comment.
This is now released and includes fix for dequelabs/axe-core#3753.
Suggested change
| "axe-core": "4.5.0", | |
| "axe-core": "4.5.1", |
There was a problem hiding this comment.
@AriPerkkio thank you for the update :) I updated the PR to also include the corresponding change in the package-lock.json
AriPerkkio
approved these changes
Nov 2, 2022
|
Heya folks, thanks for waiting til that patch came through, I'll get an update out soon! |
|
Will sort this on your behalf, dont worry about updating this pr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #250