Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

Upgrade to CRA 1.0.10 #49

Merged
merged 3 commits into from
Aug 24, 2017
Merged

Upgrade to CRA 1.0.10 #49

merged 3 commits into from
Aug 24, 2017

Conversation

Grsmto
Copy link
Contributor

@Grsmto Grsmto commented Jul 25, 2017

Neverbland now maintains his own fork of Create React App: as advised by Dan here, it's easier to fork and setup your own react-scripts.
All the Webpack config that was previously in the Neverbuild is now externalised to our fork.
This way Neverbuild will be easier to maintain.
Usage is the same as before, download/clone repo and follow install instructions.

@woffleloffle
Copy link

There's a whole bunch of stuff in src/containers/shell.js pertaining to a current client project in this commit. Perhaps just refactor some of that before we merge this?

@Grsmto
Copy link
Contributor Author

Grsmto commented Jul 25, 2017

Oops. Should be fixed.

@woffleloffle
Copy link

The tests yarn test fails with:

$ yarn test
yarn test v0.27.5
$ react-scripts test --env=jsdom
- Validation Error:

  Module ./node_modules/@neverbland/react-scripts/config/polyfills.js in the setupFiles option was not found.

  Configuration Documentation:
  https://facebook.github.io/jest/docs/configuration.html

error Command failed with exit code 1.

Adding the polyfills.js file back into @neverbland/create-react-app fixes the issue.
I'll create a pull request in the other project. Once I've done that, we can close and merge this?

@Grsmto
Copy link
Contributor Author

Grsmto commented Jul 25, 2017

The file shouldn't be there as we don't use it and we use Polyfill.io instead. So instead of adding it back we should change the tests.
Thanks for this!

@woffleloffle
Copy link

Okay, cool. Would you do the necessary?
We can catch up about this tomorrow :)

@Grsmto Grsmto merged commit 52facad into master Aug 24, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants