Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix remaining EOF validation issues #7556

Merged

Conversation

shemnon
Copy link

@shemnon shemnon commented Oct 5, 2024

Changes

Fix the remaining EOF validation issues

  • Check for required exit from returning code section (RETF or JUMPF)
  • prevent JUMPF from non-returning into returning code sections
  • consider ContainerKind from pyspec tests when running validion tests
  • pass the worklet validation mode to validation unadjusted
  • validate deep for RETURNCONTRACT

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Notes on testing

Tests are the pyspec tess

Documentation

Requires documentation update

  • Yes
  • No

Requires explanation in Release Notes

  • Yes
  • No

* Check for required exit
* prevent JUMPF from non-returning into returning
* respect `ContainerKind` from pyspec tests
* pass the worklet container kind to validation unadjusted
* validate deep for RETURNCONTRACT
Copy link
Member

@benaadams benaadams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shemnon you sir are a gentleman and a scholar

@benaadams benaadams merged commit 370c2c3 into NethermindEth:feature/evm/eof Oct 5, 2024
60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants