Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix argument null checks #7466

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Fix argument null checks #7466

merged 1 commit into from
Sep 20, 2024

Conversation

rubo
Copy link
Contributor

@rubo rubo commented Sep 19, 2024

Changes

Fixed argument null checks.

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

@rubo rubo requested a review from benaadams September 19, 2024 20:55
benaadams
benaadams approved these changes Sep 19, 2024
View reviewed changes
Copy link
Member

@benaadams benaadams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested an upgrade to .NET 9 I see?

@LukaszRozmej
Copy link
Member

We will probably remove this class in .Net 9

@rubo
Copy link
Contributor Author

rubo commented Sep 20, 2024

Tested an upgrade to .NET 9 I see?

Yes. The PR is on the way.

@rubo rubo merged commit 4829206 into master Sep 20, 2024
66 checks passed
@rubo rubo deleted the fix/arg-null-checks branch September 20, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benaadams benaadams benaadams approved these changes

@MarekM25 MarekM25 MarekM25 approved these changes

@LukaszRozmej LukaszRozmej LukaszRozmej approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rubo @LukaszRozmej @benaadams @MarekM25