-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Direct fail create tx rather than throwing exceptions #7436
Conversation
@@ -526,8 +526,7 @@ protected virtual void ExecuteEvmCall( | |||
|
|||
if (substate.ShouldRevert || substate.IsError) | |||
{ | |||
if (Logger.IsTrace) | |||
Logger.Trace("Restoring state from before transaction"); | |||
if (Logger.IsTrace) Logger.Trace("Restoring state from before transaction"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
goto Fail;
here too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You get redund on revert would cause it to skip
spentGas = Refund...
} | ||
catch (Exception ex) when (ex is EvmException or OverflowException) // TODO: OverflowException? still needed? hope not | ||
{ | ||
if (Logger.IsTrace) Logger.Trace($"EVM EXCEPTION: {ex.GetType().Name}:{ex.Message}"); | ||
WorldState.Restore(snapshot); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
goto Fail;
here too? (probably not needed as it is next instruction?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just falls through
Changes
Types of changes
What types of changes does your code introduce?
Testing
Requires testing