Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Min time between induced gcs #7432

Merged
merged 11 commits into from
Sep 16, 2024
Merged

Min time between induced gcs #7432

merged 11 commits into from
Sep 16, 2024

Conversation

benaadams
Copy link
Member

Resolves #7431

Changes

  • Add min time between forced GCs
  • Add periodic timer to GC during idle
  • GC on background thread

Types of changes

What types of changes does your code introduce?

  • Optimization

Testing

Requires testing

  • No

LukaszRozmej
LukaszRozmej requested changes Sep 14, 2024
View reviewed changes
Copy link
Member

@LukaszRozmej LukaszRozmej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move this code to separate component like we have GCKeeper?

@benaadams
Copy link
Member Author

Can we move this code to separate component like we have GCKeeper?

Moved to separate type; also added some coordination with the GCKeeper

@benaadams benaadams merged commit 50420be into master Sep 16, 2024
66 checks passed
@benaadams benaadams deleted the min-time-gc branch September 16, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukaszRozmej LukaszRozmej LukaszRozmej approved these changes

Assignees
No one assigned
Labels
performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Recent memory optimizations made archive sync significantly slower
2 participants
@benaadams @LukaszRozmej