Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prewarm tx addresses in parallel #7423

Merged
merged 7 commits into from
Sep 14, 2024
Merged

Prewarm tx addresses in parallel #7423

merged 7 commits into from
Sep 14, 2024

Conversation

benaadams
Copy link
Member

Changes

  • Prewam addresses only; in parallel to prewarming full txs (Sender+To)
    • If prewarming is slowed by actually processing the tx, the Accounts are still being preloaded
  • Include beacon state root warming as part of this

Types of changes

What types of changes does your code introduce?

  • Optimization

Testing

Requires testing

  • No

LukaszRozmej
LukaszRozmej reviewed Sep 13, 2024
View reviewed changes
Copy link
Member

@LukaszRozmej LukaszRozmej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we build general mechanism?

src/Nethermind/Nethermind.Blockchain/BeaconBlockRoot/BeaconBlockRootHandler.cs Outdated Show resolved Hide resolved
src/Nethermind/Nethermind.Blockchain/BeaconBlockRoot/IBeaconBlockRootHandler.cs Outdated Show resolved Hide resolved
src/Nethermind/Nethermind.Consensus/Processing/BlockCachePreWarmer.cs Outdated Show resolved Hide resolved
src/Nethermind/Nethermind.Consensus/Processing/BlockCachePreWarmer.cs Outdated Show resolved Hide resolved
src/Nethermind/Nethermind.Consensus/Processing/BlockCachePreWarmer.cs Outdated Show resolved Hide resolved
@benaadams benaadams merged commit 60159fb into master Sep 14, 2024
66 checks passed
@benaadams benaadams deleted the address-warmer branch September 14, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukaszRozmej LukaszRozmej LukaszRozmej approved these changes

Assignees
No one assigned
Labels
performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benaadams @LukaszRozmej