-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce memory use during Archive Sync #7407
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! LastSeen is not needed at all for receipts and transactions. :)
Was it the reason for the memory leak?
I think TrieStore could be simplified significantly for receipts and transactions
Yes is doing 400 blk/s so doing the block allocations at a far faster rate; plus since its not going via newPayload it doesn't trigger the GCKeeper so we don't trigger the memory release GCs (GC decides we need that memory due to the high allocation rate) or the MallocTrims |
Changes
Seen when processing archive nodes (many blocks at once)
Types of changes
What types of changes does your code introduce?
Testing
Requires testing