Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor TxDecoder #7334

Merged
merged 125 commits into from
Sep 4, 2024
Merged

Refactor TxDecoder #7334

merged 125 commits into from
Sep 4, 2024

Commits on Aug 8, 2024

  1. Configuration menu
    Copy the full SHA
    3bd4a8d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f46bf79 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2024

  1. Missing assignment

    emlautarom1 committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    ed2bbab View commit details
    Browse the repository at this point in the history
  2. Renaming

    emlautarom1 committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    6ed28c8 View commit details
    Browse the repository at this point in the history
  3. Individual tx decoders

    emlautarom1 committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    f1ca0f5 View commit details
    Browse the repository at this point in the history
  4. Remove intermediate interface

    - Use dynamic for now
    emlautarom1 committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    6432a36 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    d2499e9 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    2716de6 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    9bc577f View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    03d2826 View commit details
    Browse the repository at this point in the history
  9. Remove unused code

    emlautarom1 committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    4b3b3e7 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    c6bb66f View commit details
    Browse the repository at this point in the history
  11. Add Encode to API

    emlautarom1 committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    57da69d View commit details
    Browse the repository at this point in the history
  12. Implement Encode

    emlautarom1 committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    be62cc0 View commit details
    Browse the repository at this point in the history
  13. Implement Encode

    emlautarom1 committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    5cf9633 View commit details
    Browse the repository at this point in the history
  14. Implement Encode

    emlautarom1 committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    502b313 View commit details
    Browse the repository at this point in the history
  15. Implement Encode

    emlautarom1 committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    1a38696 View commit details
    Browse the repository at this point in the history
  16. Implement Encode

    emlautarom1 committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    89045c7 View commit details
    Browse the repository at this point in the history
  17. Implement Encode

    emlautarom1 committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    0966cfa View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    fa51ef6 View commit details
    Browse the repository at this point in the history
  19. Remove encode dead code

    emlautarom1 committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    8f9188c View commit details
    Browse the repository at this point in the history
  20. Add GetLength to API

    emlautarom1 committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    5d14c62 View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    288de2c View commit details
    Browse the repository at this point in the history
  22. Remove unused imports

    emlautarom1 committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    5ce978b View commit details
    Browse the repository at this point in the history
  23. Configuration menu
    Copy the full SHA
    380eca9 View commit details
    Browse the repository at this point in the history
  24. Implement ref Decode

    emlautarom1 committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    16284c3 View commit details
    Browse the repository at this point in the history
  25. Remove redundant code

    emlautarom1 committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    3904d06 View commit details
    Browse the repository at this point in the history
  26. Implement ref Decode

    emlautarom1 committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    806830f View commit details
    Browse the repository at this point in the history
  27. Remove unused code

    emlautarom1 committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    45bf28b View commit details
    Browse the repository at this point in the history
  28. Renaming

    emlautarom1 committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    fabdcf0 View commit details
    Browse the repository at this point in the history
  29. Implement ref Decode

    emlautarom1 committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    fc9246a View commit details
    Browse the repository at this point in the history
  30. Implement ref Decode

    emlautarom1 committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    93123d5 View commit details
    Browse the repository at this point in the history
  31. Implement ref Decode

    emlautarom1 committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    7aef17e View commit details
    Browse the repository at this point in the history
  32. Code cleanup

    emlautarom1 committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    0f7dd60 View commit details
    Browse the repository at this point in the history
  33. Add Rlp Encode(...)

    emlautarom1 committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    bd9f0cf View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2024

  1. Add SignatureBuilder

    - Remove duplicated code
    emlautarom1 committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    39fd942 View commit details
    Browse the repository at this point in the history
  2. Remove duplicated code

    - Remove `ApplySignature` method
    emlautarom1 committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    bb91078 View commit details
    Browse the repository at this point in the history
  3. To file scoped namespace

    emlautarom1 committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    85032e4 View commit details
    Browse the repository at this point in the history
  4. Remove Rlp Encode(...) method

    - Lifted to `TxDecoder`
    emlautarom1 committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    57cc72f View commit details
    Browse the repository at this point in the history
  5. Reduce type switches

    emlautarom1 committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    7e5ecd0 View commit details
    Browse the repository at this point in the history
  6. Refactor code

    - Remove unused methods
    - Remove indirection
    emlautarom1 committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    da8d5fb View commit details
    Browse the repository at this point in the history
  7. Remove unused code

    emlautarom1 committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    fb2d5e2 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    0c0cf74 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    afde273 View commit details
    Browse the repository at this point in the history
  10. Remove unused method

    emlautarom1 committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    0f04a96 View commit details
    Browse the repository at this point in the history
  11. Internal method renaming

    emlautarom1 committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    33c8515 View commit details
    Browse the repository at this point in the history
  12. Formatting

    emlautarom1 committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    e90e628 View commit details
    Browse the repository at this point in the history
  13. Code refactor

    - Renaming
    - Reordering
    - Prefer explicit branching
    - Lift type checks
    emlautarom1 committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    9dffba1 View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2024

  1. Add Rlp EncodeTx(...)

    emlautarom1 committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    e7e89a8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d266e3a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    734ad27 View commit details
    Browse the repository at this point in the history
  4. Make nullable parameter

    emlautarom1 committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    cffa123 View commit details
    Browse the repository at this point in the history
  5. Make primary constructor

    emlautarom1 committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    d875802 View commit details
    Browse the repository at this point in the history
  6. Add overload to Encode

    emlautarom1 committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    ab76d62 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    143e84d View commit details
    Browse the repository at this point in the history
  8. Add default RlpBehaviors

    emlautarom1 committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    9a45130 View commit details
    Browse the repository at this point in the history
  9. Fix infinite recursion

    emlautarom1 committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    a1ea7e0 View commit details
    Browse the repository at this point in the history
  10. Remove unused params

    emlautarom1 committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    55503ed View commit details
    Browse the repository at this point in the history
  11. Default to legacy

    - Improve consistency between ref and Rlp
    emlautarom1 committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    967c9ad View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    48fefeb View commit details
    Browse the repository at this point in the history
  13. Fix incorrect type check

    emlautarom1 committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    fda0ae3 View commit details
    Browse the repository at this point in the history
  14. Remove DepositTransaction subtype

    - Too many issues for now
    - Rollback TxDecoder
    emlautarom1 committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    e6b9f7b View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    c47fc90 View commit details
    Browse the repository at this point in the history
  16. Formatting

    emlautarom1 committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    1e4eb4e View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    e28018a View commit details
    Browse the repository at this point in the history
  18. Starting from scratch

    emlautarom1 committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    be9e489 View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    4363a6e View commit details
    Browse the repository at this point in the history
  20. Cleanup flag checking

    emlautarom1 committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    7534a39 View commit details
    Browse the repository at this point in the history
  21. Reorder public methods

    emlautarom1 committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    544bdc4 View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    fba000d View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2024

  1. Configuration menu
    Copy the full SHA
    5875eb3 View commit details
    Browse the repository at this point in the history
  2. Implement ref Decode

    emlautarom1 committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    5780c19 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    7f5e34e View commit details
    Browse the repository at this point in the history
  4. Remove unused code

    emlautarom1 committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    5dcc43a View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    3c136cd View commit details
    Browse the repository at this point in the history
  6. Implement EncodeTx

    emlautarom1 committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    18b0ef5 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    9a0069a View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    f118008 View commit details
    Browse the repository at this point in the history
  9. Remove unused code

    emlautarom1 committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    44a84ae View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    e99d627 View commit details
    Browse the repository at this point in the history
  11. Implement int GetLength

    emlautarom1 committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    c546250 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    ba65b9f View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    972fdaa View commit details
    Browse the repository at this point in the history
  14. Implement int GetTxLength

    emlautarom1 committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    a4787a3 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    c58ae73 View commit details
    Browse the repository at this point in the history
  16. Remove unused code

    emlautarom1 committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    63e95fe View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    4fbea8a View commit details
    Browse the repository at this point in the history
  18. Method rename

    emlautarom1 committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    e42c558 View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    ab78b21 View commit details
    Browse the repository at this point in the history
  20. Method renaming

    emlautarom1 committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    9d0f35c View commit details
    Browse the repository at this point in the history
  21. Param renaming

    emlautarom1 committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    08f7648 View commit details
    Browse the repository at this point in the history
  22. Avoid infinite recursion

    - Picking the wrong overload
    emlautarom1 committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    f198b9c View commit details
    Browse the repository at this point in the history
  23. Remove default params

    - Makes overload selection hard to reason
    emlautarom1 committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    dadec17 View commit details
    Browse the repository at this point in the history
  24. Prefer [] instead of TryGet

    - We're throwing anyways
    emlautarom1 committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    99fd76a View commit details
    Browse the repository at this point in the history
  25. Configuration menu
    Copy the full SHA
    c5aead7 View commit details
    Browse the repository at this point in the history
  26. Param renaming

    emlautarom1 committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    22e5891 View commit details
    Browse the repository at this point in the history
  27. Configuration menu
    Copy the full SHA
    18afa9b View commit details
    Browse the repository at this point in the history
  28. Configuration menu
    Copy the full SHA
    1753ced View commit details
    Browse the repository at this point in the history
  29. Configuration menu
    Copy the full SHA
    e3a0941 View commit details
    Browse the repository at this point in the history
  30. Configuration menu
    Copy the full SHA
    a72fa67 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2024

  1. Use SignatureBuilder

    emlautarom1 committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    4c1d0e1 View commit details
    Browse the repository at this point in the history
  2. Use SignatureBuilder

    - Remove duplicated code
    emlautarom1 committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    6615d63 View commit details
    Browse the repository at this point in the history
  3. Remove redundant param

    emlautarom1 committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    496bd1b View commit details
    Browse the repository at this point in the history
  4. Remove const true

    emlautarom1 committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    f10fd4b View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    0f9d0f0 View commit details
    Browse the repository at this point in the history
  6. Configure transaction factory

    - Remove static instances
    - Formatting
    emlautarom1 committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    f29e0e6 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    faf37e4 View commit details
    Browse the repository at this point in the history
  8. Delete TxFeature

    - Not used for now
    emlautarom1 committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    f98acc6 View commit details
    Browse the repository at this point in the history
  9. Whitespace

    emlautarom1 committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    6e83af8 View commit details
    Browse the repository at this point in the history
  10. Delete old abstract class

    emlautarom1 committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    a6bfbb0 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    be50fda View commit details
    Browse the repository at this point in the history
  12. Whitespace

    emlautarom1 committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    402ce57 View commit details
    Browse the repository at this point in the history
  13. Remove nullability

    emlautarom1 committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    fe87d31 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    4b48dc2 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2024

  1. Remove lazyHash

    - Only one use case which we can manually force
    emlautarom1 committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    82d7b1f View commit details
    Browse the repository at this point in the history
  2. Remove new from TxDecoder

    emlautarom1 committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    04dd9ea View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    acaf5a5 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2024

  1. Configuration menu
    Copy the full SHA
    62a1e4e View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2024

  1. Configuration menu
    Copy the full SHA
    87fdec0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    600b16a View commit details
    Browse the repository at this point in the history
  3. Remove const from interface

    - Not used outside `BaseTxDecoder`
    emlautarom1 committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    4a92361 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2024

  1. Configuration menu
    Copy the full SHA
    3647549 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1a60acd View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2024

  1. Configuration menu
    Copy the full SHA
    19ed1f9 View commit details
    Browse the repository at this point in the history
  2. better message

    LukaszRozmej committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    35175fa View commit details
    Browse the repository at this point in the history