Memoize Keccaks #7333
Closed
Memoize Keccaks #7333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| internal readonly byte[] _bytes = bytes; | ||
| public static implicit operator BytesWrapper(byte[] bytes) => new(bytes); | ||
| public static implicit operator BytesWrapper(ReadOnlySpan<byte> bytes) => new(bytes.ToArray()); |
There was a problem hiding this comment.
Can we search by Span without allocating first, like in SpanDictionary?
There was a problem hiding this comment.
Not in the regular ConcurrentDictionary; though it should live an die pretty fast in Gen0.
Also another reason to limiting to 32 bytes
There was a problem hiding this comment.
Well it is good I made SpanConcurrentDictionary ]:->
LukaszRozmej
approved these changes
Aug 16, 2024
|
Will throw that for comaprision with master on same spec |
16 tasks
Scooletz
reviewed
Aug 16, 2024
| { | ||
| private const int CacheCount = 256; | ||
| private const int CacheMax = CacheCount - 1; | ||
| private readonly ClockCache<BytesWrapper, ValueHash256>[] _caches; |
There was a problem hiding this comment.
Quite a lot of objects here 😢
|
Closing in favour of #7336 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #7328
Changes
Types of changes
What types of changes does your code introduce?
Testing
Requires testing