Fix resources cleanup in eth/* protocols #7311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexb5dh
changed the title
alexb5dh
changed the title
alexb5dh
force-pushed
the
fix/randomly-failing-protocol-tests
branch
from
55cd6b6
to
5742b09
Compare
LukaszRozmej
approved these changes
Aug 9, 2024
src/Nethermind/Nethermind.Network/P2P/Subprotocols/Eth/PooledTxsRequestor.cs
Outdated
Show resolved
Hide resolved
src/Nethermind/Nethermind.Network/P2P/Subprotocols/Eth/PooledTxsRequestor.cs
Outdated
Show resolved
Hide resolved
…g-protocol-tests # Conflicts: # src/Nethermind/Nethermind.Network.Test/P2P/Subprotocols/Eth/V66/Eth66ProtocolHandlerTests.cs
alexb5dh
force-pushed
the
fix/randomly-failing-protocol-tests
branch
from
72f5058
to
455253f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes some of the missing
ArrayPoolListcleanups in client code and tests.Fixed:
SubprotocolException.NewPooledTransactionHashesMessage.PooledTxsRequestornot disposing some of the allocatedArrayPoolListsNethermind.Network.Test.P2P.Subprotocols.Ethfailing randomly due to someArrayPoolLists not being disposed. Should be reproducible by either running or debugging tests for multiple protocol versions in a single run.Also, optimized
ArrayPoolcopying inPooledTxsRequestor.RequestTransactionsEth66, when multiple batches are sent.What types of changes does your code introduce?
Testing
Requires testing
Documentation
Requires documentation update
Requires explanation in Release Notes