Eth_simulate blob related bugfixes #7308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukaszRozmej
requested changes
Aug 9, 2024
src/Nethermind/Nethermind.Facade/Proxy/Models/Simulate/SimulateBlockResult.cs
Outdated
Show resolved
Hide resolved
src/Nethermind/Nethermind.JsonRpc/Modules/Eth/SimulateTxExecutor.cs
Outdated
Show resolved
Hide resolved
src/Nethermind/Nethermind.Facade/Simulate/SimulateTxMutatorTracer.cs
Outdated
Show resolved
Hide resolved
src/Nethermind/Nethermind.Facade/Simulate/SimulateBridgeHelper.cs
Outdated
Show resolved
Hide resolved
src/Nethermind/Nethermind.Facade/Simulate/SimulateTransactionProcessor.cs
Outdated
Show resolved
Hide resolved
src/Nethermind/Nethermind.Facade/Simulate/SimulateBridgeHelper.cs
Outdated
Show resolved
Hide resolved
src/Nethermind/Nethermind.Facade/Simulate/SimulateBridgeHelper.cs
Outdated
Show resolved
Hide resolved
src/Nethermind/Nethermind.Facade/Simulate/SimulateBridgeHelper.cs
Outdated
Show resolved
Hide resolved
src/Nethermind/Nethermind.Evm/TransactionProcessing/TransactionProcessor.cs
Outdated
Show resolved
Hide resolved
src/Nethermind/Nethermind.Evm/TransactionProcessing/TransactionProcessor.cs
Outdated
Show resolved
Hide resolved
LukaszRozmej
approved these changes
Aug 14, 2024
kamilchodola
pushed a commit
that referenced
this pull request
Aug 14, 2024
Co-authored-by: lukasz.rozmej <lukasz.rozmej@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here we continue development of Eth_simulate feature, last time updated at 5530
In this PR we are implementing ethereum/execution-apis#484 proposal. Fixing minor issues related to protocol updates such as:
blobBaseFeefield for a block, this should not be returned as its not part of the block header.authorfield that should not be theredetected by our testing team.