Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to RocksDB v9.4.0 #7300

Merged
merged 5 commits into from
Aug 26, 2024
Merged

Upgrade to RocksDB v9.4.0 #7300

merged 5 commits into from
Aug 26, 2024

Conversation

rubo
Copy link
Contributor

@rubo rubo commented Jul 31, 2024

Changes

Upgraded RocksDB to v9.4.0.

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Database upgrade

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Notes on testing

Needs manual testing

@rubo rubo requested a review from kamilchodola July 31, 2024 19:04
@rubo
Copy link
Contributor Author

rubo commented Jul 31, 2024

@kamilchodola Could you please compare this to the current one?

@rubo rubo added the rocksdb label Jul 31, 2024
@kamilchodola
Copy link
Contributor

For future there is nice action which can compare it quite easily (create two equals envs for two nodes and spawn some rpc load tests to see any difference and then can be verified on Grafana)
https://github.com/NethermindEth/nethermind/actions/runs/10194669630

HOPE IT STILL WORKS :)

@rubo rubo marked this pull request as ready for review August 15, 2024 16:41
@LukaszRozmej
Copy link
Member

@kamilchodola can we merge it?

@kamilchodola
Copy link
Contributor

I did not had any objections merging it last time, everything looked like working smoothly. We could merge it and keep an eye on that while testing other things.

@kamilchodola
Copy link
Contributor

Memory used was reduced, no significant improvement on block processing.

@rubo rubo added this pull request to the merge queue Aug 26, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Aug 26, 2024
@benaadams benaadams added this pull request to the merge queue Aug 26, 2024
github-merge-queue bot pushed a commit that referenced this pull request Aug 26, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Aug 26, 2024
@rubo rubo merged commit bd18f29 into master Aug 26, 2024
66 checks passed
@rubo rubo deleted the feature/rocksdb-v9 branch August 26, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants