Incorrect batch unwrapping in JSON-RPC replay tool #7279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Specialize for the only use case
- Fixes double enumeration
- Broke `NullJsonRpcSubmitter` in dry runs
emlautarom1
commented
Jul 23, 2024
| yield return new JsonRpc.SingleJsonRpc(JsonDocument.Parse(single.ToString())); | ||
| } | ||
| } | ||
| yield return new JsonRpc.BatchJsonRpc(jsonDoc); |
There was a problem hiding this comment.
A double enumeration happens here: if we unwrap batches we yield the batch elements, but we also yield the batch request at the end (most likely a missing else branch)
LukaszRozmej
approved these changes
Jul 24, 2024
| yield return new JsonRpc.SingleJsonRpc(JsonDocument.Parse(single.ToString())); | ||
| } | ||
| } | ||
| yield return new JsonRpc.BatchJsonRpc(jsonDoc); |
kamilchodola
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
-d | --drymode due to incorrectnullhandling.Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?
Notes on testing
As mentioned in #6366 (comment) we need to introduce a proper test suite before adding any new features to Kute.
Documentation
Requires documentation update
Requires explanation in Release Notes