Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't limit eth_getLogs on authenticated context #7149

Merged
merged 2 commits into from
Jun 9, 2024
Merged

Don't limit eth_getLogs on authenticated context #7149

merged 2 commits into from
Jun 9, 2024

Conversation

LukaszRozmej
Copy link
Member

Changes

  • Don't limit eth_getLogs on authenticated context

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Notes on testing

Test CL's

Remarks

Can be controversial on AsyncLocal implementation?

@kamilchodola
Copy link
Contributor

Looks good, did not reproduced issue on this branch yet so probably we can merge

@LukaszRozmej LukaszRozmej marked this pull request as ready for review June 9, 2024 12:06
benaadams
benaadams approved these changes Jun 9, 2024
View reviewed changes
Copy link
Member

@benaadams benaadams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AsyncLocal 😢

@flcl42
Copy link
Contributor

flcl42 commented Jun 9, 2024 •
edited
Loading

Can we save some ticks by not having sync context?

@LukaszRozmej LukaszRozmej merged commit 04674fa into master Jun 9, 2024
68 checks passed
@LukaszRozmej LukaszRozmej deleted the fix/dont-limit-logs-on-authenticated branch June 9, 2024 19:52
kamilchodola pushed a commit that referenced this pull request Jun 10, 2024
@LukaszRozmej @kamilchodola
Don't limit eth_getLogs on authenticated context (#7149)
57d6a85
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benaadams benaadams benaadams approved these changes

@smartprogrammer93 smartprogrammer93 smartprogrammer93 approved these changes

@rjnrohit rjnrohit rjnrohit approved these changes

@rubo rubo Awaiting requested review from rubo

@flcl42 flcl42 Awaiting requested review from flcl42

@asdacap asdacap Awaiting requested review from asdacap

@MarekM25 MarekM25 Awaiting requested review from MarekM25

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@LukaszRozmej @kamilchodola @flcl42 @benaadams @smartprogrammer93 @rjnrohit