Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unified invalid blocks handling in logs #6749

Merged
merged 6 commits into from
Aug 14, 2024

Conversation

MarekM25
Copy link
Contributor

@MarekM25 MarekM25 commented Feb 19, 2024

Changes

Before the change: If we reject a block with an invalid block hash, we don't know the extra data, so we can't determine who produced it. A shared/unified message has been introduced to address this issue.. Example:
image

We should add more things to InvalidBlockHelper in future, for example, bad blocks metrics, handling via debug_getBadBlocks.

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Logging

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Notes on testing

I am going to review existing tests, logging change. Testing - don't merge

@MarekM25 MarekM25 marked this pull request as draft February 19, 2024 13:57
@MarekM25 MarekM25 marked this pull request as ready for review August 14, 2024 14:42
@MarekM25 MarekM25 merged commit 52ecf6d into master Aug 14, 2024
66 checks passed
@MarekM25 MarekM25 deleted the logging/bad_block_message_adjustment branch August 14, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants