Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Serialize Json direct to Http PipeWriter" (#6369) #6613

Closed
wants to merge 1 commit into from

Conversation

benaadams
Copy link
Member

Contributes to #6556

Changes

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Copy link
Member

@LukaszRozmej LukaszRozmej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you elaborate where is the leak?

@benaadams
Copy link
Member Author

Can you elaborate where is the leak?

This isn't the leak we are looking for ; as it's not a leak perse more a very large memory reservation due to the sizes of the Json responses, so it has the memory reasdy for the next very large response. It allocates less per request but hangs onto a lot of memory between requests:

image

@LukaszRozmej
Copy link
Member

LukaszRozmej commented Jan 25, 2024

Can you elaborate where is the leak?

This isn't the leak we are looking for ; as it's not a leak perse more a very large memory reservation due to the sizes of the Json responses, so it has the memory reasdy for the next very large response. It allocates less per request but hangs onto a lot of memory between requests:

image

200MB is not the end of the world if it is pooled memory as you say so it increases performance and decreases GC. Are there any parameters to control it?

Maybe leave it as is?

@benaadams
Copy link
Member Author

Will keep this as is as other source identified

@benaadams benaadams closed this Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants