Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Halve Discovery MaxOutgoingMessagePerSecond #6538

Closed
wants to merge 1 commit into from
Closed

Halve Discovery MaxOutgoingMessagePerSecond #6538

wants to merge 1 commit into from

Conversation

benaadams
Copy link
Member

@benaadams benaadams commented Jan 14, 2024 •
edited by rubo
Loading

Changes

  • In Fix excessive timer allocation in rate limiter #6354 I fixed in advertent over allocation and addition throttling from CPU burn; however this may have increased the rate of MaxOutgoingMessagePerSecond (to its stated number). This looks like it has caused additional network instability and bandwidth usage, so halve the rate here.

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)

Testing

Requires testing

  • Yes
  • No

@benaadams benaadams added the bug label Jan 14, 2024
@benaadams benaadams requested a review from rubo as a code owner January 14, 2024 11:11
@benaadams benaadams marked this pull request as draft January 14, 2024 11:12
@asdacap
Copy link
Contributor

asdacap commented Jan 14, 2024

What threshold works for your internet?

@benaadams
Copy link
Member Author

What threshold works for your internet?

Seems happy atm; but going to let it brew for a while

@benaadams
Copy link
Member Author

K, might not be this, still had a glitch out
image

@benaadams
Copy link
Member Author

Will wait till receipts stop syncing to assess

@benaadams
Copy link
Member Author

I've only got CL running and having same issues. Not sure its us.

@benaadams benaadams closed this Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rubo rubo rubo approved these changes

@LukaszRozmej LukaszRozmej LukaszRozmej approved these changes

@asdacap asdacap Awaiting requested review from asdacap

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@benaadams @asdacap @rubo @LukaszRozmej