Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TxPool: handling blob txs reorgs #5954

Closed
wants to merge 155 commits into from
Closed

TxPool: handling blob txs reorgs #5954

wants to merge 155 commits into from

Conversation

marcindsobczak
Copy link
Contributor

@marcindsobczak marcindsobczak commented Jul 21, 2023 •
edited
Loading

Changes

  • add to TxPoolConfig option of enabling support for blob txs reorgs BlobReorgsSupportEnabled, true by default
  • add new db dedicated for processed blob transactions
  • after inclusion of blob tx, it is removed from standard mempool/db. All txs from processed block are added to processed txs db where blockNumber is a key and value is array of txs
  • in case of reorg, if we have in db txs from reorged block, they are readded to standard mempool/db and removed from processed db
  • add ProcessedTransactionsDbCleaner which is triggered by ForkChoiceUpdated and is removing all KeyValuePairs with blockNumber not higher than finalized block, as reorg is not possible after finalization
  • update TxPool report to include db writes/reads

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Documentation

Requires documentation update

  • Yes
  • No

Requires explanation in Release Notes

  • Yes
  • No

@marcindsobczak
add extensions
d366741
@marcindsobczak
adjust filters
53fcffa
@marcindsobczak
add tests
2bc9be5
@marcindsobczak
Merge branch 'feature/txpool_filters' into feature/txpool_4844txs
79588f0
@marcindsobczak
draft
1a25885
@marcindsobczak
fix metrics
414fb8f
@marcindsobczak
fix tx type, add test for replacing
c508930
@marcindsobczak
adjust blob replacement comparer
45115fa
@marcindsobczak
add blob tx db and metrics
c0db165
@marcindsobczak
fix test
15087f4
@marcindsobczak
resurrect old TxStorage class and adjust a bit for blobs
c6ea9fe
@marcindsobczak
pass blob storage to tx pool, adjust tests
d1c66c1
@marcindsobczak
handle db writes/reads and add test
a6a65c5
@marcindsobczak
recreate light collection after restart
5cf90f5
@marcindsobczak
adjust broadcaster test
2e91dcb
@marcindsobczak
cosmetic
b38a40d
@marcindsobczak
add broadcaster test
7f3df36
@marcindsobczak
add todos
a3d86d7
@marcindsobczak
add MaxFeePerDataGas check when updating gas bottleneck
109cca4
@marcindsobczak
regression test for MaxFeePerDataGas check
0b8f72d
@marcindsobczak
cosmetic
5a20486
@marcindsobczak
Merge remote-tracking branch 'origin/master' into feature/txpool_4844txs
5a6b7fe
@marcindsobczak
unify & simplify tests
a6e1e16
@marcindsobczak
cosmetics in BlobTxStorage
6596c1d
@marcindsobczak
add AcceptTxResult dedicated for rejected replacements
07870f1
@marcindsobczak
adjust tests, add test for blob tx replacements
73872e1
@marcindsobczak
simplify TxPool
b11a27d
@marcindsobczak
refactor to reuse id of deprecated result
5da9488
@marcindsobczak
simplify filters
3071be3
@marcindsobczak
add configurable sizes of blob pool and blob cache
9cc03cc
marcindsobczak and others added 25 commits September 11, 2023 12:44
@marcindsobczak
Merge remote-tracking branch 'origin/master' into feature/txpool_4844txs
59fb8a3
@marcindsobczak
save sender to db
416ab31
@marcindsobczak
fix recreating light collection
c236326
@marcindsobczak
Merge remote-tracking branch 'origin/master' into feature/txpool_4844txs
056fb15
@marcindsobczak
adjust EthStats to show sum of blob and non-blob txs
1b5c1cc
@marcindsobczak
fix
051c89b
@marcindsobczak
make blob support configurable
d16bf52
@marcindsobczak
optimize snapshots
6f211b6
@marcindsobczak
fix blob support disabled
96352c8
@marcindsobczak
don't request blob txs if blob support disabled
8f6b3f4
@marcindsobczak
fix tests
b100533
@marcindsobczak
fix files encoding
7de7fe6
@marcindsobczak
fix test
bbe23e3
@marcindsobczak
cosmetics
cc33167
@marcindsobczak
add MaxPendingTxsPerSenderFilter
8173c81
@marcindsobczak
add test
6195466
@marcindsobczak
Merge remote-tracking branch 'origin/feature/txpool_4844txs' into fea…
3468681 
…ture/txpool_4844txs_reorgs

# Conflicts:
#	src/Nethermind/Nethermind.Consensus.AuRa/InitializationSteps/InitializeBlockchainAuRa.cs
#	src/Nethermind/Nethermind.Db/StandardDbInitializer.cs
#	src/Nethermind/Nethermind.Init/Steps/InitializeBlockchain.cs
#	src/Nethermind/Nethermind.Network.Benchmark/Eth62ProtocolHandlerBenchmarks.cs
#	src/Nethermind/Nethermind.TxPool/BlobTxStorage.cs
#	src/Nethermind/Nethermind.TxPool/ITxPoolConfig.cs
#	src/Nethermind/Nethermind.TxPool/TxPoolConfig.cs
@marcindsobczak
post merge fixes
d49dacf
@marcindsobczak
disable blob pool by default
ee1891b
@MarekM25
cosmetic refactoring
d2131bd
@MarekM25
revert previous change
ae671d4
@marcindsobczak
fix tests after making blob pool disabled by default
ccc1799
@marcindsobczak
Merge remote-tracking branch 'origin/feature/txpool_4844txs' into fea…
d535ae1 
…ture/txpool_4844txs
@marcindsobczak
useBlobDb -> useBlobsDb
0bb5cf0
@marcindsobczak
Merge remote-tracking branch 'origin/feature/txpool_4844txs' into fea…
be99b65 
…ture/txpool_4844txs_reorgs

# Conflicts:
#	src/Nethermind/Nethermind.Init/Steps/InitDatabase.cs
Base automatically changed from feature/txpool_4844txs to master October 17, 2023 13:01
@marcindsobczak marcindsobczak mentioned this pull request Nov 7, 2023
Merged
16 tasks
@marcindsobczak
Copy link
Contributor Author

Closed in favor of #6254

@rubo rubo deleted the feature/txpool_4844txs_reorgs branch December 20, 2023 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukaszRozmej LukaszRozmej LukaszRozmej requested changes

@flcl42 flcl42 Awaiting requested review from flcl42

@benaadams benaadams Awaiting requested review from benaadams

@MarekM25 MarekM25 Awaiting requested review from MarekM25

Assignees
No one assigned
Labels
eip-4844
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marcindsobczak @LukaszRozmej @flcl42 @MarekM25