Minor PostMergeBlocksSyncPeerAllocationStrategy refactor
#4546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
|
Probably needs to be rabased (157 modifications) |
…ategy to BySpeedStrategy
asdacap
force-pushed
the
minor-refactor-extract-byspeed-strategy-logic
branch
from
c4a9c07
to
c888360
Compare
|
Rebased, should be only 3 files. |
MarekM25
reviewed
Sep 21, 2022
MarekM25
reviewed
Sep 21, 2022
| } | ||
|
|
||
| long averageTransferSpeed = GetSpeed(nodeStatsManager, info) ?? 0; |
There was a problem hiding this comment.
It all goes to BySpeedStrategy
|
I dont thing anything will go to master anymore |
MarekM25
approved these changes
Sep 21, 2022
smartprogrammer93
pushed a commit
that referenced
this pull request
Sep 27, 2022
…ategy to BySpeedStrategy (#4546)
smartprogrammer93
pushed a commit
that referenced
this pull request
Sep 27, 2022
…ategy to BySpeedStrategy (#4546)
smartprogrammer93
pushed a commit
that referenced
this pull request
Sep 27, 2022
…ategy to BySpeedStrategy (#4546)
Andrew-Pohl
pushed a commit
to fuseio/nethermind
that referenced
this pull request
Oct 7, 2022
…ategy to BySpeedStrategy (NethermindEth#4546) (NethermindEth#4659) Co-authored-by: Amirul Ashraf <asdacap@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract speed related logic to BySpeedStrategy.
Changes:
Types of changes
What types of changes does your code introduce?
Put an
xin the boxes that applyTesting
Requires testing
In case you checked yes, did you write tests??
Comments about testing , should you have some (optional)
Goerli can sync to head
Further comments (optional)
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...