Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix peer header when no peers to show #4411

Merged
merged 4 commits into from
Aug 11, 2022
Merged

Fix peer header when no peers to show #4411

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a15174e
Fix peer header when no peers to show
smartprogrammer93 Aug 11, 2022
04e4896
Only order once
smartprogrammer93 Aug 11, 2022
f4c9c19
Better fix maybe
smartprogrammer93 Aug 11, 2022
f075dbe
Applying lukasz suggestion
smartprogrammer93 Aug 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/Nethermind/Nethermind.Synchronization/Peers/SyncPeersReport.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,8 @@ public void WriteFullReport()

RememberState(out bool _);
_stringBuilder.AppendLine($"Sync peers - Initialized: {_currentInitializedPeerCount} | All: {_peerPool.PeerCount} | Max: {_peerPool.PeerMaxCount}");
AddPeerHeader();
if (OrderedPeers.Any())
AddPeerHeader();
foreach (PeerInfo peerInfo in OrderedPeers)
{
_stringBuilder.AppendLine();
Expand Down Expand Up @@ -91,7 +92,8 @@ public void WriteShortReport()
}

_stringBuilder.AppendLine($"Sync peers {_currentInitializedPeerCount}({_peerPool.PeerCount})/{_peerPool.PeerMaxCount}");
AddPeerHeader();
if (OrderedPeers.Any(p => !p.CanBeAllocated(AllocationContexts.All)))
AddPeerHeader();
foreach (PeerInfo peerInfo in OrderedPeers.Where(p => !p.CanBeAllocated(AllocationContexts.All)))
{
_stringBuilder.AppendLine();
Expand Down