Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change regex to get correct changelog value #4400

Merged
merged 2 commits into from
Aug 15, 2022
Merged

Conversation

FalcoXYZ
Copy link
Contributor

Changes the regex to match the changelog in github releases properly.

Changes:

  • changed the regex in the discord announcement action to better match the changelog.

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests??

  • Yes
  • No

Comments about testing , should you have some (optional)

Further comments (optional)

Tested locally with multiple release changelogs (1.13.2 till 1.13.6) and works as it should.

Changes the regex to match the changelog in github releases properly.
@FalcoXYZ FalcoXYZ requested a review from matilote August 10, 2022 08:25
@FalcoXYZ FalcoXYZ self-assigned this Aug 10, 2022
@FalcoXYZ FalcoXYZ marked this pull request as ready for review August 15, 2022 13:47
@AntiD2ta AntiD2ta merged commit 2b5a801 into master Aug 15, 2022
@AntiD2ta AntiD2ta deleted the fix/discord-ann branch August 15, 2022 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants