Fix/buffer reallocation #4306
Merged
Fix/buffer reallocation #4306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanishqjasoria
force-pushed
the
fix/buffer-reallocation
branch
from
97cd792
to
c62f112
Compare
tanishqjasoria
added a commit
that referenced
this pull request
Aug 3, 2022
* serialization * reuse buffer
LukaszRozmej
added a commit
that referenced
this pull request
Aug 4, 2022
#4292) * change to zero serializer * fix get length * temp change * change to zero intializer * update message pad * add and use zero serializer * use zero serializer * update messgae serialization service * rewrite functions to use byte buffer * update P2P messages serializer * update serializers * update tests * remove zero message serializer * fix failing tests * fix netty rlp has been read * fix length calc * fix serializers * update * optimize byte array allocations * fix span creation * remove redundant to array * fix block body serializer * fix receipts serializer * Fix/buffer reallocation (#4306) * serialization * reuse buffer * Fix reciepts decoder * fix reciepts serializer * fix zero packet splitter * implement func to use stream encoder * Clean up * fix ChainLevelDecoder * add comment * add GetLength private to reduce length calculations * convert all to inner serializer to use get length to allocate buffer * Kill more allocations * kill bit more allocations * less allocs * fix build * use rlp stream * remove rlp.encode from zeroPacketSplitter * restore WriteAdaptivePacketType(in IByteBuffer buffer) and fix tests * fix length calc * Remove test console outputs Co-authored-by: lukasz.rozmej <lukasz.rozmej@gmail.com>
tanishqjasoria
added a commit
that referenced
this pull request
Aug 16, 2022
* serialization * reuse buffer
tanishqjasoria
added a commit
that referenced
this pull request
Sep 16, 2022
* serialization * reuse buffer
tanishqjasoria
added a commit
that referenced
this pull request
Oct 10, 2022
* serialization * reuse buffer
tanishqjasoria
added a commit
that referenced
this pull request
Oct 14, 2022
* serialization * reuse buffer
tanishqjasoria
added a commit
that referenced
this pull request
Oct 17, 2022
* serialization * reuse buffer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Reallocation of buffer in NettyDiscoveryHandler
Types of changes
What types of changes does your code introduce?
Put an
xin the boxes that applyTesting
Requires testing
In case you checked yes, did you write tests??