Remove one ToArray

NethermindEth · Nov 27, 2023 · edd15d9 · edd15d9
1 parent ef6c4e5
commit edd15d9
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 5 deletions.
diff --git a/src/Nethermind/Nethermind.Blockchain/BlockTree.cs b/src/Nethermind/Nethermind.Blockchain/BlockTree.cs
@@ -1606,10 +1606,7 @@ public void ForkChoiceUpdated(Hash256? finalizedBlockHash, Hash256? safeBlockHas
                 _metadataDb.Set(MetadataDbKeys.SafeBlockHash, Rlp.Encode(SafeHash!).Bytes);
             }
         }
-
-        public Block[] GetInvalidBlocks()
-        {
-            return _invalidBlocks.ToArray().Select(x => x.Value).ToArray();
-        }
+
+        public Block[] GetInvalidBlocks() => _invalidBlocks.GetValues();
     }
 }
diff --git a/src/Nethermind/Nethermind.Core/Caching/LruCache.cs b/src/Nethermind/Nethermind.Core/Caching/LruCache.cs
@@ -133,6 +133,19 @@ public KeyValuePair<TKey, TValue>[] ToArray()
             return array;
         }
 
+        [MethodImpl(MethodImplOptions.Synchronized)]
+        public TValue[] GetValues()
+        {
+            int i = 0;
+            TValue[] array = new TValue[_cacheMap.Count];
+            foreach (KeyValuePair<TKey, LinkedListNode<LruCacheItem>> kvp in _cacheMap)
+            {
+                array[i++] = kvp.Value.Value.Value;
+            }
+
+            return array;
+        }
+
         private void Replace(TKey key, TValue value)
         {
             LinkedListNode<LruCacheItem>? node = _leastRecentlyUsed;