Fix KeyExists leak (#6353)

NethermindEth · Dec 11, 2023 · 600b7b6 · 600b7b6
1 parent c284fa1
commit 600b7b6
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/src/Nethermind/Nethermind.Core/IKeyValueStore.cs b/src/Nethermind/Nethermind.Core/IKeyValueStore.cs
@@ -30,7 +30,14 @@ public interface IReadOnlyKeyValueStore
         /// <returns>Can return null or empty Span on missing key</returns>
         Span<byte> GetSpan(ReadOnlySpan<byte> key, ReadFlags flags = ReadFlags.None) => Get(key, flags);
 
-        bool KeyExists(ReadOnlySpan<byte> key) => GetSpan(key).IsNull();
+        bool KeyExists(ReadOnlySpan<byte> key)
+        {
+            Span<byte> span = GetSpan(key);
+            bool result = span.IsNull();
+            DangerousReleaseMemory(span);
+            return result;
+        }
+
         void DangerousReleaseMemory(in Span<byte> span) { }
     }