Write lock on whole PrepareRequest

NethermindEth · Dec 20, 2023 · 51b2871 · 51b2871
1 parent 2f0366b
commit 51b2871
Showing 1 changed file with 3 additions and 7 deletions.
diff --git a/src/Nethermind/Nethermind.Synchronization/FastBlocks/FastHeadersSyncFeed.cs b/src/Nethermind/Nethermind.Synchronization/FastBlocks/FastHeadersSyncFeed.cs
@@ -299,7 +299,7 @@ private bool HasDependencyToProcess
 
         public override Task<HeadersSyncBatch?> PrepareRequest(CancellationToken cancellationToken = default)
         {
-            _resetLock.EnterReadLock();
+            _resetLock.EnterWriteLock();
             try
             {
                 do
@@ -320,23 +320,19 @@ private bool HasDependencyToProcess
 
                 if (batch is not null)
                 {
-                    lock (_handlerLock)
-                    {
-                        _sent.Add(batch);
-                    }
+                    _sent.Add(batch);
                     if (batch.StartNumber >= (LowestInsertedBlockHeader?.Number ?? 0) - FastBlocksPriorities.ForHeaders)
                     {
                         batch.Prioritized = true;
                     }
 
                     LogStateOnPrepare();
                 }
-
                 return Task.FromResult(batch);
             }
             finally
             {
-                _resetLock.ExitReadLock();
+                _resetLock.ExitWriteLock();
             }
         }