Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

onboarding exercise #1942

Closed
wants to merge 2 commits into from
Closed

onboarding exercise #1942

wants to merge 2 commits into from

Conversation

onuruci
Copy link
Contributor

@onuruci onuruci commented Jul 11, 2024

No description provided.

derrix060
derrix060 reviewed Jul 11, 2024
View reviewed changes
Copy link
Contributor

@derrix060 derrix060 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a juno developer, but it would be nice to have more details in the commit message and some documentations for the functions :)

@onuruci
Copy link
Contributor Author

onuruci commented Jul 11, 2024

Just completed onboarding exercises this is not to be merged

@kirugan kirugan added the onboarding Part of onboarding exercise pack label Jul 11, 2024
@rianhughes
Copy link
Contributor

rianhughes commented Jul 23, 2024 •
edited

This solution looks good to me, nice work! Closing to keep PR list tidy.

@rianhughes rianhughes closed this Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derrix060 derrix060 derrix060 left review comments

@rianhughes rianhughes rianhughes left review comments

Assignees
No one assigned
Labels
onboarding Part of onboarding exercise pack
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@onuruci @rianhughes @derrix060 @kirugan