Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing some todos #1925

Merged
merged 1 commit into from
Aug 6, 2024
Merged

Fixing some todos #1925

merged 1 commit into from
Aug 6, 2024

Conversation

pnowosie
Copy link
Contributor

@pnowosie pnowosie commented Jul 4, 2024

No description provided.

sync/snap_server.go Outdated Show resolved Hide resolved
@pnowosie pnowosie marked this pull request as ready for review August 1, 2024 08:53
core/trie/trie.go Outdated Show resolved Hide resolved
sync/snap_server_test.go Outdated Show resolved Hide resolved
@pnowosie pnowosie force-pushed the pnowosie/fixing-todos branch 2 times, most recently from 55dbca7 to d58ab63 Compare August 6, 2024 11:37
@pnowosie
Copy link
Contributor Author

pnowosie commented Aug 6, 2024

Ok, I think we can merge it into snap2 and will continue to integrate it into main

@pnowosie pnowosie merged commit a0c2826 into p2p/snap2 Aug 6, 2024
0 of 4 checks passed
@pnowosie pnowosie deleted the pnowosie/fixing-todos branch August 6, 2024 13:40
pnowosie pushed a commit that referenced this pull request Aug 8, 2024
This is a combination of 24 commits.
pnowosie pushed a commit that referenced this pull request Aug 16, 2024
This is a combination of 24 commits.
pnowosie pushed a commit that referenced this pull request Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants