Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort buffered transactions #1882

Merged
merged 14 commits into from
Aug 2, 2024
Merged

Sort buffered transactions #1882

merged 14 commits into from
Aug 2, 2024

Conversation

ashu26jha
Copy link
Contributor

@ashu26jha ashu26jha commented May 28, 2024

Implements #903, sorting the buffered txns in the increasing contract addresses. They do give slightly better benchmarking results

Benchmarks from the main branch:

ashutoshjha@Ashutoshs-MacBook-Air juno % go test ./... -bench=MainnetBlock -benchmem
PASS
ok      github.com/NethermindEth/juno/adapters/sn2core  0.920s

Benchmarks from current branch

ashutoshjha@Ashutoshs-MacBook-Air juno % go test ./... -bench=MainnetBlock -benchmem
PASS
ok      github.com/NethermindEth/juno/adapters/sn2core  0.727s

@ashu26jha ashu26jha added Optimisation New feature or request DB Database labels May 28, 2024
Copy link

codecov bot commented May 28, 2024

Codecov Report

Attention: Patch coverage is 93.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 75.42%. Comparing base (10ba647) to head (670fb66).

Files Patch % Lines
core/state.go 93.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1882      +/-   ##
==========================================
+ Coverage   75.40%   75.42%   +0.01%     
==========================================
  Files         100      100              
  Lines        8983     8990       +7     
==========================================
+ Hits         6774     6781       +7     
  Misses       1605     1605              
  Partials      604      604              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

core/state.go Outdated Show resolved Hide resolved
core/state.go Show resolved Hide resolved
core/state.go Outdated Show resolved Hide resolved
db/buffered_transaction.go Outdated Show resolved Hide resolved
core/state.go Outdated Show resolved Hide resolved
core/state.go Outdated Show resolved Hide resolved
core/state.go Show resolved Hide resolved
core/state.go Outdated Show resolved Hide resolved
core/state.go Outdated Show resolved Hide resolved
core/state.go Outdated Show resolved Hide resolved
core/state.go Outdated Show resolved Hide resolved
@ashu26jha ashu26jha requested a review from kirugan August 2, 2024 07:09
@kirugan kirugan merged commit cdc43f6 into main Aug 2, 2024
10 checks passed
@kirugan kirugan deleted the sort-buffered-txs branch August 2, 2024 17:34
AnkushinDaniil pushed a commit that referenced this pull request Aug 12, 2024
Co-authored-by: Kirill <paltsev.kir@gmail.com>
Co-authored-by: IronGauntlets <aneequesafdar@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DB Database Optimisation New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants