Remove decommissioned networks #1880

pnowosie · 2024-05-24T07:58:58Z

Remove decommissioned networks: Goerli, Goerli2 and Integration.

codecov · 2024-05-24T08:59:38Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.15%. Comparing base (692bd49) to head (8742d96).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1880      +/-   ##
==========================================
- Coverage   78.39%   78.15%   -0.25%     
==========================================
  Files         100      100              
  Lines        9041     9073      +32     
==========================================
+ Hits         7088     7091       +3     
- Misses       1327     1345      +18     
- Partials      626      637      +11

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

.github/workflows/run-node-on-new-vm.yml

core/state_update_test.go

@wojciechos

fix the test - 🙇 with @wojciechos

kirugan · 2024-08-22T22:17:03Z

blockchain/blockchain_test.go

@@ -443,125 +443,6 @@ func TestState(t *testing.T) {
 	})
 }

-func TestEvents(t *testing.T) {


Is this test obsolete?

I moved it into a possibly better place

juno/rpc/events_test.go

Line 27 in c391201

func TestEvents(t *testing.T) {

kirugan · 2024-08-22T22:19:53Z

core/block_test.go

-			number: 1,
-			chain:  utils.Goerli,
-			name:   "goerli network (pre 0.7.0 without sequencer address)",
-		},


are you sure that these tests should be removed? because sequencerFallback is part of our logic in old hashes, maybe there is an alternative in mainnet ?

I've found already 2 mainnet examples in this test if I am not mistaken

juno/core/block_test.go

Lines 31 to 44 in 7383569

{

// block 0: main

// https://alpha-mainnet.starknet.io/feeder_gateway/get_block?blockNumber=0

number: 0,

chain: utils.Mainnet,

name: "mainnet (pre 0.7.0 without sequencer address)",

},

{

// block 833: main

// https://alpha-mainnet.starknet.io/feeder_gateway/get_block?blockNumber=833

number: 833,

chain: utils.Mainnet,

name: "mainnet 833 (post 0.7.0 without sequencer address)",

},

kirugan · 2024-08-22T22:20:13Z

core/block_test.go

-		{
-			number: 283364,
-			chain:  utils.Integration,
-			name:   "Block 283364 with Declare v2",


same, specific tx type with version

These one I looked for but found only version v3 - let me run my scripts over the weekend 🤔

added Sepolia block #7

kirugan · 2024-08-22T22:25:05Z

core/block_test.go

@@ -204,12 +126,12 @@ func TestBlockHash(t *testing.T) {
 	})

 	t.Run("no error if block is unverifiable", func(t *testing.T) {


new version of this test doesn't test what it was intended to. Here is metadata of goerli:

UnverifiableRange: []uint64{119802, 148428},

119801 is beginning of unverifiable range

If we don't need this logic anymore it's even better, but I'm not sure. cc @IronGauntlets

kirugan · 2024-08-22T22:26:36Z

core/class_test.go

 	gw := adaptfeeder.New(client)
 	tests := []struct {
 		classHash       string
 		checkNoCompiled bool
 	}{
 		{
-			// https://external.integration.starknet.io/feeder_gateway/get_class_by_hash?classHash=0x1cd2edfb485241c4403254d550de0a097fa76743cd30696f714a491a454bad5
-			classHash: "0x1cd2edfb485241c4403254d550de0a097fa76743cd30696f714a491a454bad5",
+			// https://alpha-mainnet.starknet.io/feeder_gateway/get_class_by_hash?classHash=<calss_hash>


missing class_hash

The url will be the same besides the class_hash parameter. I moved the comment above, and fixed the typo.

sync/sync_test.go

pnowosie force-pushed the pnowosie/1753-Remove_dependency_on_Goerli_testnets branch from a5493cb to 3cecdca Compare May 24, 2024 08:51

pnowosie force-pushed the pnowosie/1753-Remove_dependency_on_Goerli_testnets branch 3 times, most recently from 18d12b6 to 84d71ff Compare May 29, 2024 09:08

pnowosie requested review from wojciechos, IronGauntlets and rianhughes May 29, 2024 10:33

wojciechos reviewed May 29, 2024

View reviewed changes

.github/workflows/run-node-on-new-vm.yml Outdated Show resolved Hide resolved

pnowosie force-pushed the pnowosie/1753-Remove_dependency_on_Goerli_testnets branch 2 times, most recently from dccfc48 to ac1a6eb Compare May 29, 2024 14:34

pnowosie marked this pull request as ready for review May 29, 2024 14:34

rianhughes reviewed May 30, 2024

View reviewed changes

core/state_update_test.go Show resolved Hide resolved

pnowosie requested review from wojciechos and rianhughes June 3, 2024 11:51

pnowosie force-pushed the pnowosie/1753-Remove_dependency_on_Goerli_testnets branch from ac1a6eb to feedd25 Compare June 4, 2024 11:34

pnowosie mentioned this pull request Jun 24, 2024

TestTransaction - Remove Goerli #1914

Closed

kirugan force-pushed the main branch from dfbedca to ad21b2e Compare June 28, 2024 13:09

pnowosie force-pushed the pnowosie/1753-Remove_dependency_on_Goerli_testnets branch from feedd25 to 0d6bdf8 Compare July 3, 2024 13:29

pnowosie mentioned this pull request Jul 3, 2024

rpc specs and some more tests #1834

Draft

pnowosie force-pushed the pnowosie/1753-Remove_dependency_on_Goerli_testnets branch 3 times, most recently from 0887b2c to 6de2b42 Compare July 15, 2024 09:44

pnowosie force-pushed the pnowosie/1753-Remove_dependency_on_Goerli_testnets branch 2 times, most recently from 9eda3bc to 3510edd Compare July 26, 2024 13:21

pnowosie requested review from kirugan and removed request for wojciechos and rianhughes July 26, 2024 14:51

remove Goerli, Goerli2 & Integration networks

7383569

fix the test - 🙇 with @wojciechos

pnowosie force-pushed the pnowosie/1753-Remove_dependency_on_Goerli_testnets branch from 3510edd to 7383569 Compare August 22, 2024 12:25

linter. Still 4 tests need to be fixed

44d6416

kirugan reviewed Aug 22, 2024

View reviewed changes

sync/sync_test.go Outdated Show resolved Hide resolved

pnowosie added 2 commits August 23, 2024 13:22

[WIP] Kirill comments

0c62013

fixed test (almost right data)

8742d96

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove decommissioned networks #1880

Remove decommissioned networks #1880

pnowosie commented May 24, 2024 •

edited

Loading

codecov bot commented May 24, 2024 •

edited

Loading

kirugan Aug 22, 2024

pnowosie Aug 23, 2024

kirugan Aug 22, 2024

pnowosie Aug 23, 2024

kirugan Aug 22, 2024

pnowosie Aug 23, 2024

pnowosie Aug 23, 2024 •

edited

Loading

kirugan Aug 22, 2024

kirugan Aug 22, 2024

kirugan Aug 22, 2024

pnowosie Aug 23, 2024

	{
	// block 0: main
	// https://alpha-mainnet.starknet.io/feeder_gateway/get_block?blockNumber=0
	number: 0,
	chain: utils.Mainnet,
	name: "mainnet (pre 0.7.0 without sequencer address)",
	},
	{
	// block 833: main
	// https://alpha-mainnet.starknet.io/feeder_gateway/get_block?blockNumber=833
	number: 833,
	chain: utils.Mainnet,
	name: "mainnet 833 (post 0.7.0 without sequencer address)",
	},

		@@ -204,12 +126,12 @@ func TestBlockHash(t *testing.T) {
		})

		t.Run("no error if block is unverifiable", func(t *testing.T) {

Remove decommissioned networks #1880

Are you sure you want to change the base?

Remove decommissioned networks #1880

Conversation

pnowosie commented May 24, 2024 • edited Loading

codecov bot commented May 24, 2024 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pnowosie Aug 23, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pnowosie commented May 24, 2024 •

edited

Loading

codecov bot commented May 24, 2024 •

edited

Loading

pnowosie Aug 23, 2024 •

edited

Loading